Skip basic auth when auth token is set #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, I also rename basicAuth to authBasic for naming consistency with authToken.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
- Coverage 74.25% 73.11% -1.15%
==========================================
Files 40 43 +3
Lines 3604 3678 +74
==========================================
+ Hits 2676 2689 +13
- Misses 789 850 +61
Partials 139 139 ☔ View full report in Codecov by Sentry. |
|
LGTM, thanks a lot for the amazing PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #509
Skip basic auth when auth token is set
In addition, I also rename
basicAuthtoauthBasicfor naming consistency withauthToken