-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token auth #508
Token auth #508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 40 40
Lines 3604 3604
=======================================
Hits 2676 2676
Misses 789 789
Partials 139 139 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for submitting the PR! I have added a few comment, I appreciate if you could make some small adjustments when you have time.
5ca2b4b
to
51a0b6b
Compare
Hi, I have implemented the changes your requested. Thank you so much for your instructions and if there is anything i need to add or change let me know. ps i ran into some weird git issues so i apologize for some of the unnecessary commits |
Looks good to me. Thank you so much for the great work! |
Adds #505
This is my attempt to add basic simple Auth Token Authentication.
It works in a similar way to Basic Auth but can be expanded to be able to use JWTs( I can add that but it requires adding more libraries which i didn't want to do)
To-do:
When either Basic Auth or Auth Token is turned on the WebUI doesn't work which i believe is a feature since the webui is not configured to send tokens or credentials
Wrong Auth Token

Correct Auth Token
