Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load admin config for all commands before action #244

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Load admin config for all commands before action #244

merged 2 commits into from
Aug 9, 2022

Conversation

yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented Aug 9, 2022

This PR is related to #216

@yottahmd yottahmd changed the title Add baseConfig parameter to admin config Load admin config for all commands before action Aug 9, 2022
@yottahmd yottahmd marked this pull request as ready for review August 9, 2022 15:01
@yottahmd yottahmd merged commit dac81b6 into main Aug 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #244 (9f6e38c) into main (1c9e6e2) will increase coverage by 0.16%.
The diff coverage is 92.94%.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   86.15%   86.31%   +0.16%     
==========================================
  Files          46       46              
  Lines        3286     3282       -4     
==========================================
+ Hits         2831     2833       +2     
+ Misses        326      322       -4     
+ Partials      129      127       -2     
Impacted Files Coverage Δ
cmd/dagu.go 72.91% <76.92%> (+0.69%) ⬆️
internal/admin/config.go 84.25% <95.65%> (+2.60%) ⬆️
cmd/scheduler.go 100.00% <100.00%> (+9.09%) ⬆️
cmd/server.go 81.25% <100.00%> (+7.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yottahmd yottahmd deleted the develop branch August 9, 2022 15:03
@yottahmd yottahmd added this to the v1.7.0 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants