[Asset Selection] Remove unneeded shared component #27667
+1,973
−502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add-filters-to-base-asset-selection
…add-filters-to-base-asset-selection
salazarm
requested review from
bengotow,
hellendag,
benpankow and
clairelin135
hellendag
approved these changes
Feb 7, 2025
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b06a7ff. |
Base automatically changed from
salazarm/add-filters-to-base-asset-selection
to
master
February 7, 2025 19:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
No longer using a shared component for the Antlr Lexer/Parser because we're instead consolidating on a single grammar with all attributes supported, and then adding extra validation on top to error if specific filters are used in Plus vs OSS vs branch deployments