-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Ver 0.10.2) dagit's "Tick History" chart no longer works, just shows constant spinning circle #3626
Comments
I can't repro this locally... Is there an error in the JavaScript console? Feel free to ping me (prha) in the elementl slack to help debug... |
I switched to personal Ubuntu. running a toy pipeline, everything local with default sqlite db, and using Firefox browser ver 84.0.2 Sorry, I have little JS dev knowledge. So I'm assuming you're wanting to see output from Firefox's web console. Initially I am getting no output in Firefox's web console: Then I happen to look at the web console again and this showed up: Zoomed in: |
This was very helpful, thanks! This hit a bug when there's no tick history and the schedule has never been turned on. I'll also get a reasonable message surfaced and push that out in |
Ah, I'll keep this open until |
@prha Thanks! I look forward to the 0.10.3 release today or whenever it is ready. |
I've upgraded, but the problem still remains. On the first schedule run, I did get an error:
I was curious if the existing data in the Postgres was maybe causing problems, so I deleted all the dagster-related tables, re-ran the schedule. Still no change, but no longer getting that error above. No errors showing up in the web console either or in the dagit terminal or the daemon terminal: |
Sorry about that. I'm going to run a patch release to pick up the fix for this (unrelated to the original error). I think if you start the daemon using |
Hi @pybokeh, this is a new error from the latest release. Thanks for raising this- will get a fix out asap |
@prha No worries! I am amazed at what dagit does or what it is able to do with so much going on underneath the hood. Just to clarify, which problem should go away? The |
I have a fix ready for the |
Hmm, curious why you're still getting the spinner. And I guess you're not getting any errors in the console? Would love to set up a time to dig into it with you. |
@prha I just checked, after 17 runs, no output in the web console on my person machine. I can be free after 4pm EST. You can hit me up on dagster's Slack (Daniel Kim). Yes it is strange. The tick history was working fine for me with 0.10.0 and 0.10.1. I am puzzled that this problem can not be duplicated I'm assuming. |
Reopening until this is out in the release, but the main underlying issue was around fetching ticks for schedules added to the repo using the lazy repository dictionary. Short-term work around would be to use the list-based repository definition. Fixing rev is here: |
Summary: We were not handling the jobState graphql queries correctly when schedules were loaded using the lazy repository dictionary definition. This diff hides `jobs` (but does not throw) as a repository dictionary key and adds sensors. It also merges schedules and sensors into jobs, making sure that the `jobState` query resolves correctly. I changed some of the graphql test structure to load a lazy repository dictionary definition as one of the multi_location test variants. Then I hooked up the jobs tests to query the secondary location repository and made sure it loaded correctly. Should resolve dagster-io#3626 Test Plan: bk Reviewers: dgibson, johann Reviewed By: dgibson Differential Revision: https://dagster.phacility.com/D6359
Actually, the spinning circle is running even before turning on the schedule. In other words, when viewing the page for the first time, the spinning circle animation is already running.
My setup:
I will report back using default sqlite db and see if the problem persists.
The text was updated successfully, but these errors were encountered: