-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[@dagster-io/ui] Output cjs (#11594)
### Summary & Motivation Our ESM output of `@dagster-io/ui` doesn't appear to work with Nextjs apps, though it does work with CRA apps. Just build to cjs instead, which should work for both. Also produce split built files at `components` so that imports can do: ``` import {Box} from '@dagster-io/ui/lib/components/Box';` ``` and correctly get both the implementation import and the generated `Box.d.ts` file that is adjacent to it. ### How I Tested These Changes With a personal Next.js project, import `Box` as above and verify that the build works correctly (including types) and that the Box renders properly. Repeat with one of our internal CRA apps, verify same. Verify that existing `@dagster-io/ui` imports work correclty.
- Loading branch information
Showing
3 changed files
with
12 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b1ff76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
dagit-storybook – ./js_modules/dagit/packages/ui
dagit-storybook.vercel.app
dagit-storybook-git-master-elementl.vercel.app
dagit-storybook-elementl.vercel.app