console: fix console.dir crash on a revoked proxy

Fixes: nodejs#43095

Signed-off-by: Daeyeon Jeong [email protected]

lib/internal/util/inspect.js

@@ -761,6 +761,9 @@ function formatValue(ctx, value, recurseTimes, typedArray) {
   if (proxy !== undefined) {
     if (ctx.showProxy) {
       return formatProxy(ctx, proxy, recurseTimes);
+    } else if (proxy === null) {
+      // The proxy is revoked
+      return formatValue(ctx, proxy, 0);
     }
     value = proxy;
   }
@@ -1966,9 +1969,10 @@ function hasBuiltInToString(value) {
   // Prevent triggering proxy traps.
   const getFullProxy = false;
   const proxyTarget = getProxyDetails(value, getFullProxy);
-  if (proxyTarget !== undefined) {
-    value = proxyTarget;
+  if (proxyTarget === undefined || proxyTarget === null) {
+    return false;
   }
+  value = proxyTarget;
 
   // Count objects that have no `toString` function as built-in.
   if (typeof value.toString !== 'function') {

test/parallel/test-console-issue-43095.js

@@ -0,0 +1,18 @@
+'use strict';
+
+require('../common');
+const assert = require('node:assert');
+const { inspect } = require('node:util');
+
+const r = Proxy.revocable({}, {});
+r.revoke();
+
+console.dir(r.proxy);
+console.dir(r);
+console.log(r.proxy);
+
+assert.strictEqual(inspect(r.proxy), 'null');
+assert.strictEqual(
+  inspect(r.proxy, { showProxy: true }),
+  'Proxy [ null, null ]',
+);