netfilter: ctnetlink: put back references to master ct and expect obj…

…ects We have to put back the references to the master conntrack and the expectation that we just created, otherwise we'll leak them. Fixes: 0ef71ee ("netfilter: ctnetlink: refactor ctnetlink_create_expect") Reported-by: Tim Wiess <[email protected]> Signed-off-by: Pablo Neira Ayuso <[email protected]>
dabrace · Jul 10, 2015 · 95dd865 · 95dd865
1 parent a7d35f9
commit 95dd865
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
@@ -2995,11 +2995,6 @@ ctnetlink_create_expect(struct net *net, u16 zone,
 	}
 
 	err = nf_ct_expect_related_report(exp, portid, report);
-	if (err < 0)
-		goto err_exp;
-
-	return 0;
-err_exp:
 	nf_ct_expect_put(exp);
 err_ct:
 	nf_ct_put(ct);