fix bug: shinyjs functions inside modules using 'selector' instead of…

… 'id' didn't work
daattali · Apr 16, 2018 · 8627e85 · 8627e85
1 parent 401846b
commit 8627e85
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: shinyjs
 Title: Easily Improve the User Experience of Your Shiny Apps in Seconds
-Version: 1.0.1.9001
+Version: 1.0.1.9002
 Authors@R: person("Dean", "Attali", email = "[email protected]",
     role = c("aut", "cre"))
 Description: Perform common useful JavaScript operations in Shiny apps that will

diff --git a/NEWS.md b/NEWS.md
@@ -3,6 +3,7 @@
 - New fearure: `hide()`/`show()`: only bubble up the DOM tree to the nearest input container if the current element is an input; fixes #153
 - New feature: `onevent()` returns the `offsetX` and `offsetY` event properties
 - New feature: `onevent()` accepts a `properties` parameter that allows the user to retrieve additional properties that are not whitelisted by default; fixes #159
+- Fix bug: shinyjs functions used inside a module with a `selector` argument instead of an `id` argument didn't work
 
 # shinyjs 1.0
 

diff --git a/R/jsFunc-aaa.R b/R/jsFunc-aaa.R
@@ -30,7 +30,7 @@ jsFuncHelper <- function(fxn, params) {
 
   # respect Shiny modules/namespaces
   if (inherits(session , "session_proxy")) {
-    if ("id" %in% names(params)) {
+    if ("id" %in% names(params) && !is.null(params[['id']])) {
       params[['id']] <- session$ns(params[['id']])
     }
   }