Simplify usage of selection.join with transitions

[curran]

Related to #257, an alternative to #285, this change would allow .join to handle the case that transitions are returned by onenter and/or onupdate. It would support the same simplified usage documented in #257, but leave the behavior of .merge unchanged. Just putting this out there as an alternative to consider, as it targets the main pain point, rather than introducing new behavior in .merge to accomplish the same goal.

This works because of selection.selection.

[mbostock]

I think we should do this earlier so that selection.join is guaranteed to return a selection, like so:

function(onenter, onupdate, onexit) {
  var enter = this.enter(), update = this, exit = this.exit();
  if (typeof onenter === "function") {
    enter = onenter(enter);
    if (enter) enter = enter.selection();
  } else {
    enter = enter.append(onenter + "");
  }
  if (onupdate != null) {
    update = onupdate(update);
    if (update) update = update.selection();
  }
  if (onexit == null) exit.remove(); else onexit(exit);
  return enter && update ? enter.merge(update).order() : update;
}

[curran]

Oh yes good catch! Thank you.

[curran]

Remaining work:

• Tests
• Docs

[curran]

I just realized that if #285 lands in addition to this, then we will not need the following:

if (update) update = update.selection();

This is because the updated .merge implementation from #285 will do this internally.

[mbostock]

I just realized that if #285 lands in addition to this, then we will not need the following:

if (update) update = update.selection();

This is because the updated .merge implementation from #285 will do this internally.

No, you’ll still want it because otherwise selection.join could return a transition if there’s no enter selection:

  return enter && update ? enter.merge(update).order() : update;

[curran]

Added tests and docs. Ready for review. Thanks!

[curran]

Hooray! Thank you @mbostock 🙏