Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selection.merge(transition) should error. #208

Closed
mbostock opened this issue Mar 17, 2019 · 2 comments · Fixed by #210
Closed

selection.merge(transition) should error. #208

mbostock opened this issue Mar 17, 2019 · 2 comments · Fixed by #210
Milestone
2.0

Comments

@mbostock
Copy link
Member

transition.merge(selection) already errors because transition.merge enforces a matching transition._id, but selection.merge does not make a similar safety check.
@mbostock
Copy link
Member Author

On second thought, this isn’t going to be backwards-compatible, strictly-speaking, so… I guess never mind.

@mbostock
Copy link
Member Author

We can do it for 2.0.

@mbostock mbostock reopened this Mar 17, 2019
@mbostock mbostock added this to the 2.0 milestone Mar 17, 2019
@mbostock mbostock mentioned this issue Mar 18, 2019
Merged
9 tasks
mbostock added a commit that referenced this issue Mar 18, 2019
@mbostock
Fix #208 - strict merge.
c0ba436
mbostock added a commit that referenced this issue Jul 29, 2019
@mbostock
Fix #208 - strict merge.
54f6e6b
@Fil Fil closed this as completed in #210 Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

2.0 d3/d3-selection
1 participant
@mbostock