This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Fixes #1497 - Do not query app versions in MarathonHealthCheckManager #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protected[this] case class ActiveHealthCheck( | ||
| healthCheck: HealthCheck, | ||
| actor: ActorRef) | ||
|
|
||
| protected[this] var appHealthChecks = Map[AppVersion, Set[ActiveHealthCheck]]() | ||
| protected[this] var appHealthChecks: Map[PathId, Map[Timestamp, Set[ActiveHealthCheck]]] = Map.empty |
There was a problem hiding this comment.
Create a map with default Value, so you can get rid of all subsequent getOrlElse statements.
|
Cool! Especially since the statuses() performance is greatly improved. |
….statuses and make MarathonHealthCheckManager data structures more efficient
kolloch
force-pushed
the
pk/1497_health_statuses_more_efficient
branch
from
8c5a0cf to
4279b6b
Compare
|
Followed up on your suggestion. Thanks! |
|
👍 |
aquamatthias
added a commit
that referenced
this pull request
May 27, 2015
…_efficient Fixes #1497 - Do not query app versions in MarathonHealthCheckManager
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.statuses(appId: PathId)
and make MarathonHealthCheckManager data structures more efficient