Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

pods allow duplicate endpoint ports #5116

Closed
jdef opened this issue Feb 6, 2017 · 1 comment
Closed

pods allow duplicate endpoint ports #5116

jdef opened this issue Feb 6, 2017 · 1 comment
Assignees

Comments

@jdef
Copy link
Contributor

jdef commented Feb 6, 2017

this can lead to confusing/surprising results w/ respect to service discovery. we strictly forbid this via validation.

for example:

{
  "id": "/nginx",
  "containers": [
    {
      "name": "container-1",
      "resources": { "cpus": 1, "mem": 128 },
      "endpoints": [
        {
          "name": "http",
          "containerPort": 80,
          "hostPort": 0,
          "protocol": [ "tcp" ],
          "labels": { "VIP_0": "1.1.1.1:80" }
        },
        {
          "name": "httpp",
          "containerPort": 80,
          "hostPort": 0,
          "protocol": [ "tcp" ],
          "labels": { "VIP_0": "1.1.1.1:80" }
        }
      ],
      "image": { "id": "nginx", "kind": "DOCKER" }
    }
  ],
  "scaling": { "kind": "fixed", "instances": 1 },
  "networks": [ { "name": "dcos", "mode": "container" } ]
}
@jdef jdef added this to the Marathon 1.4 milestone Feb 6, 2017
@aquamatthias aquamatthias self-assigned this Feb 8, 2017
@aquamatthias
Copy link
Contributor

Path is here: https://phabricator.mesosphere.com/D496

jeschkies pushed a commit that referenced this issue Feb 10, 2017
… and container ports.

Summary: See #5116

Test Plan: sbt test

Reviewers: unterstein, jenkins, jdef

Reviewed By: unterstein, jenkins, jdef

Subscribers: marathon-team

Differential Revision: https://phabricator.mesosphere.com/D496
@jdef jdef removed the cherry-pick label Feb 10, 2017
@d2iq-archive d2iq-archive locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants