Delete Street Scene GLBs/Parking Alignment Edits #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
d-wasserman
commented
Jan 11, 2023
•
d-wasserman
commented
- Delete Assets in Esri.Lib, Use Reference CSV for assets: Delete duplicated Vehicle & Street Scene GLBs that exist in Esri.lib, and depend on the Assset_Metadata.csv. This drops the repo size a significant chunk and makes the rule easier to port. This also lead to improvements in Asset quality because the first set of vehicles and similar assets pulled did not have reflectivity maps and similar details. How to deal with van vehicles in allocations should be revisited later (Microtransit in HOV lanes? etc).
- Fix Rail Textures: Rail Tracks textures were not working as expected. Changes in projection fixed this.
- Parallel Parking to use alignToGeometryBBox: First change to use alignScopeToGeometryBBox instead of ToGeometry for parallel parking vehicle insertion. Other areas might benefit from this, but that is to be determined. This provided marginal benefits in placement on severely angled streets tested, but only a few types were tried.
Use CSVs to reference path locations per the request of CL at Esri. This seems to work on a PC test in CityEngine, but the fraction of Vans might be more explicit or half . Thank for suggestions!
New vehicles in Esri.lib are superior and are supported by the asset CSV. Delete old assets.
Use complete folder for assets if the Asset_Metadata.csv is present. This will help force a transition. Fix projection of rail transit pavement. Simplify rule. TODO to fix microtransit inclusion in cars used.
Reclassify transit connect vehicle as microtransit.
These assets are in Esri Lib and better represented through the Asset CSV. There is some clunky behavior when selecting sidewalks and streets, but the enums do work as intended.
Based on some suggestions of Esri, I am trying to use alignScopeToGeometryBBOX for parking rather than to geometry. This could be in theory applied in other areas, but the potential impacts are unclear. This seems to provide better performance for parking spaces specifically, and the pattern used here would likely work elsewhere. Angle issues still exist at curbside drop off or longer polygons, but this seems to work better. Might for others as well that are clearly rectangular shapes.
Based on some suggestions of Esri, I am trying to use alignScopeToGeometryBBOX for parking rather than to geometry. This could be in theory applied in other areas, but the potential impacts are unclear. This seems to provide better performance for parking spaces specifically, and the pattern used here would likely work elsewhere. Angle issues still exist at curbside drop off or longer polygons, but this seems to work better. Might for others as well that are clearly rectangular shapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.