Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cefpython123 #669

Merged
merged 33 commits into from
Feb 17, 2025
+31,910 −21,434
Merged

Cefpython123 #669

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
523362f
py3 update for automate-git.py and automate.py
Jan 28, 2024
5a5df95
--disable-syntax-validation option at gclient has been removed from u…
Jan 28, 2024
41e0b97
Add support for Python 3.8 and Upgrade Cython (#594)
gmjosack Feb 14, 2021
92a6c69
update spotify prebuilt cef url
Jan 28, 2024
e8a5dc7
fix
Jan 29, 2024
f49ab60
add support for cef 123 version
May 11, 2024
24abdc3
Fix CefListValue "int index" params (#461).
cztomczak Jan 14, 2020
5309afe
getting partical fix from https://github.com/cztomczak/cefpython/comm…
May 12, 2024
0a6a22d
getting partical fix (part 2) from https://github.com/cztomczak/cefpy…
May 12, 2024
daacb75
undo previous unittest change (partly)
May 12, 2024
748f104
Fix V8ContextHandler.OnContextCreated and OnContextReleased (#484).
cztomczak Jan 17, 2020
cd70070
add python311 support
May 12, 2024
e67aa83
undo previous accidental change to common.py
May 12, 2024
2c8819c
update misc place for py311 support
May 12, 2024
af864f0
better handle MainMessageLoopExternalPump, remove some previouis test…
May 19, 2024
cffcf93
add mainframe validation at javascript_bindings.pyx
May 25, 2024
b7aa32c
undo unexpected change to src/compile_time_constatns.pxi
linesight Feb 10, 2025
ffbfdad
not use obsolete base/cef_ptr_util.h
linesight Feb 10, 2025
b3d38bc
add back cef_mac.h and cef_linux.h
linesight Feb 11, 2025
615af96
address pull request feedback
linesight Feb 11, 2025
52edcd8
restore previous language_level line at cython_setup.py
linesight Feb 11, 2025
720782b
remove obsolete stuff
linesight Feb 11, 2025
44fda11
Merge branch 'master' into cefpython123
linesight Feb 13, 2025
3550c40
delete previously commented code
linesight Feb 15, 2025
c68cb2e
address pull request feedback
linesight Feb 15, 2025
cf1778b
delete previously commented code
linesight Feb 15, 2025
541f136
update osr_test.py to respect current event data type
linesight Feb 15, 2025
c4c0806
delete OnPluginCrashed; add initial implementation of CanSendCookie a…
linesight Feb 16, 2025
8286fb1
add back upstream cef 6312 branch's cef_types_linux.h and cef_types_m…
linesight Feb 17, 2025
099f5a1
remove commented SendProcessMessage from cef_browser.pxd
linesight Feb 17, 2025
eddbce1
one more place to use str type for uniqueFrameId
linesight Feb 17, 2025
db1d3ac
bring back SendFocusEvent in browser.pyx for backward compatibility
linesight Feb 17, 2025
1585ccf
replace ondomread.py example using example.com, as google.com website…
linesight Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/javascript_bindings.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,10 @@ cdef class JavascriptBindings:
for methodName in self.objects[objectName]:
methods[methodName] = None
objects[objectName] = methods
pyBrowser.GetMainFrame().SendProcessMessage(cef_types.PID_RENDERER,
0, "DoJavascriptBindings", [{
mainFrame = pyBrowser.GetMainFrame()
if mainFrame.IsValid():
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we print a log message when frame is invalid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference log or not log when frame is invalid

mainFrame.SendProcessMessage(cef_types.PID_RENDERER,
mainFrame.frameId, "DoJavascriptBindings", [{
"functions": functions,
"properties": properties,
"objects": objects,
Expand Down