Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not a clean shutdown in examples, when closing app while browser is still loading a website #282

Closed
cztomczak opened this issue Dec 11, 2016 · 1 comment
Closed

Not a clean shutdown in examples, when closing app while browser is still loading a website #282

cztomczak opened this issue Dec 11, 2016 · 1 comment
Labels
bug
Milestone
v55

Comments

@cztomczak
Copy link
Owner

Steps to reproduce:

  1. Type "test" in Google
  2. Load speed test website
  3. Close app while it's still loading
  4. Error in logs occurs:
[CEF Python] ERROR: Shutdown called, but there are still browser references alive

It doesn't reproduce every time. Issue occurs in all examples.

I will try to fix this by always forcing shutdown of browsers and then run message loop work for at least 0.2 sec. Currently it runs for 0.1 sec. Issue also occurs in hello_world.py which uses MessageLoop(), but looks like calling some message loop work here is also required.
cztomczak added a commit that referenced this issue Dec 15, 2016
@cztomczak
Update to Chrome 55.0.2883.59 and CEF 3.2883.1539.gd7f087e (#271).
bfc0a25 
Update to Cython 0.25.2.

Fix Certificate Transparency support causing some SSL sites fail
to load after some time (#279).

Fix ApplicationSettings.cache_path not working (#283).

Fix: Not a clean shutdown in examples, when closing app while browser
is still loading a website (#282).

Fix loading local filesystem urls that contained any of ? & =
characters (#273).

Fix Request.SetPostData and GetPostData segmentation faults (#228).

Add ApplicationSettings.net_security_expiration_enabled.

Update ExecuteJavascript docs with scriptUrl="" and startLine=1
default params. Also worth noting that ExecuteJavascript crashed
in earlier CEF versions when startLine wasn't provided or was <= 0
(Issue #268).

Add a test that measures execution time for calling Python function
from javascript and then js callback.

Add Contributing guidelines / Issue template.

Update automate.py, include ceftests executable.
@cztomczak
Copy link
Owner Author

Fixed in bfc0a25. Related comments and new code here:

cefpython/src/cefpython.pyx

Line 861 in bfc0a25

# Run some message loop work, force closing browsers and then run
. v55.2 released, please test.

@cztomczak cztomczak mentioned this issue Dec 17, 2016
Closed
@cztomczak cztomczak added this to the v55 milestone Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v55
Development

No branches or pull requests
1 participant
@cztomczak