Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cython to latest #110

Closed
GoogleCodeExporter opened this issue Aug 28, 2015 · 3 comments
Closed

Update Cython to latest #110

GoogleCodeExporter opened this issue Aug 28, 2015 · 3 comments
Milestone
v55

Comments

@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Aug 28, 2015 •
edited by cztomczak
Loading

A thorough testing will be required, as version 0.20 breaks some things. While
doing a quick testing, one issue was found so far.

Issue with strings

The Debug() function needs to accept both unicode and bytes strings. In version 0.19.2 of Cython you could pass unicode string and it was converted automatically, but with the new version an error is throwed:

 TypeError: Expected str, got unicode

The Debug() function:
https://code.google.com/p/cefpython/source/browse/cefpython/utils.pyx?r=2f6f611c2fcf#20

Called from CreateJavascriptCallback():
https://code.google.com/p/cefpython/source/browse/cefpython/javascript_callback_cef3.pyx?r=2f6f611c2fcf

The functionName param was decoded from the cefpython IPC message using the json library, and the json library automatically converted the string to unicode.

There might be more places where unicode is passed and it would throw an error.
@GoogleCodeExporter GoogleCodeExporter mentioned this issue Aug 28, 2015
Closed
@cztomczak cztomczak added this to the Python 3 milestone Jan 26, 2016
@GoogleCodeExporter GoogleCodeExporter mentioned this issue Jan 26, 2016
Open
@cztomczak cztomczak mentioned this issue Feb 11, 2016
Closed
@cztomczak cztomczak changed the title Update Cython to version 0.20 Update Cython to the latest Cython 0.23.4 Feb 12, 2016
@cztomczak cztomczak modified the milestones: Chrome 47, Python 3 Feb 12, 2016
@cztomczak cztomczak changed the title Update Cython to the latest Cython 0.23.4 Update to the latest Cython 0.23.4 Feb 12, 2016
@cztomczak cztomczak mentioned this issue Feb 12, 2016
Closed
79 tasks
@cztomczak cztomczak changed the title Update to the latest Cython 0.23.4 Update to Cython 0.24.1 Sep 17, 2016
cztomczak added a commit that referenced this issue Sep 17, 2016
@cztomczak
Add experimental Python 3 support (#121, #183) among others.
6f0d9b3 
Add hello_world.py example (#207).

Update to Cython 0.24.1 (#110).

Test with Python 3.4.5 (#121) on Ubuntu 14.04 by running
the hello_world.py example. No other examples were run,
so there still may be bugs.

Expose new funcs in the cefpython module: CreateBrowser, ExceptHook,
GetAppPath.

Add --fast flag to compile.py for faster build time of the cefpython
module. Don't use it for building official binary distrib.
@cztomczak
Copy link
Owner

Updated to Cython 0.24.1 in commit 6f0d9b3. The issue with strings is not yet fixed in all places (eg. Debug func), further testing is required. Tested only with hello_world.py example.

cztomczak added a commit that referenced this issue Sep 18, 2016
@cztomczak
Add unit tests (#59) and fix Python 3 issue (#121,#183) among others.
80d7c5a 
Improve shutting down cleanly with ExceptHook.

Fix issue with str/bytes passed to Debug() function (#110).
@cztomczak cztomczak changed the title Update to Cython 0.24.1 Update Cython version Oct 28, 2016
cztomczak added a commit that referenced this issue Oct 28, 2016
@cztomczak
Update to Chrome 55.0.2883.21 and CEF 3.2883.1506.ga6c42a7 (#263), and
59a9aa1 
others.

This is CEF Python 55.1 beta release with Chrome 55 from beta channel.

Add support for Python 3.6 (#121).

Update to Cython 0.25.1 (#110).

Build cefpython .so modules using clean Python installations as in pyenv
to avoid invalid symbols being embedded in the .so module (#266).

Update CEF include/.
Update patches/.

Update compile.py. Run unit tests first and don't run gtk3 example
temporarily until #261 is fixed. Check if Cython version installed
is the same as specified in tools/requirements.txt.

Update examples - print filename when logging messages.
@zhaozhangpeng zhaozhangpeng mentioned this issue Nov 26, 2016
Closed
@cztomczak cztomczak changed the title Update Cython version Update Cython to latest Dec 9, 2016
cztomczak added a commit that referenced this issue Dec 9, 2016
@cztomczak
Update to Chrome 54.0.2840.99 and CEF 3.2840.1518.gffd843c (#272).
1da0110 
Update to Cython 0.25.2 (#110).

Changes in API:
- Add ApplicationSettings.net_security_expiration_enabled

Key changes in upstream CEF between commits 7fe3d03...ffd843c (CEF Python 54.0 ... 54.1):
- Update to Chromium version 54.0.2840.99
- Fix PDF rendering with OSR
- Add CefRequestHandler::OnSelectClientCertificate (allows for client certificate selection programmatically)
- Fix load error when using Request->SetUrl when url contains double byte characters
- Fix crash related to channel ID support, disable channel ID support
- Net security (CT, HSTS) expiration based on build age is now disabled by default. Configurable with CefSettings.enable_net_security_expiration.
- New web plugin API: CefRegisterCdmCallback, CefRegisterWidevineCdm
@cztomczak
Copy link
Owner

Updated to Cython 0.25.2 with no problems.

@cztomczak cztomczak modified the milestones: v55, Python 3 Feb 24, 2017
@cztomczak
Copy link
Owner

See #250 for future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v55
Development

No branches or pull requests
2 participants
@cztomczak @GoogleCodeExporter