Remove BrowserSettings.javascript_open_windows_disallowed option (#403)

README.md

@@ -436,7 +436,6 @@ Additional information for v31.2 release:
   * [file_access_from_file_urls_allowed](api/BrowserSettings.md#file_access_from_file_urls_allowed)
   * [image_load_disabled](api/BrowserSettings.md#image_load_disabled)
   * [javascript_disabled](api/BrowserSettings.md#javascript_disabled)
-  * [javascript_open_windows_disallowed](api/BrowserSettings.md#javascript_open_windows_disallowed)
   * [javascript_close_windows_disallowed](api/BrowserSettings.md#javascript_close_windows_disallowed)
   * [javascript_access_clipboard_disallowed](api/BrowserSettings.md#javascript_access_clipboard_disallowed)
   * [local_storage_disabled](api/BrowserSettings.md#local_storage_disabled)

api/API-index.md

@@ -122,7 +122,6 @@
   * [file_access_from_file_urls_allowed](BrowserSettings.md#file_access_from_file_urls_allowed)
   * [image_load_disabled](BrowserSettings.md#image_load_disabled)
   * [javascript_disabled](BrowserSettings.md#javascript_disabled)
-  * [javascript_open_windows_disallowed](BrowserSettings.md#javascript_open_windows_disallowed)
   * [javascript_close_windows_disallowed](BrowserSettings.md#javascript_close_windows_disallowed)
   * [javascript_access_clipboard_disallowed](BrowserSettings.md#javascript_access_clipboard_disallowed)
   * [local_storage_disabled](BrowserSettings.md#local_storage_disabled)

api/BrowserSettings.md

@@ -17,7 +17,6 @@ Table of contents:
   * [file_access_from_file_urls_allowed](#file_access_from_file_urls_allowed)
   * [image_load_disabled](#image_load_disabled)
   * [javascript_disabled](#javascript_disabled)
-  * [javascript_open_windows_disallowed](#javascript_open_windows_disallowed)
   * [javascript_close_windows_disallowed](#javascript_close_windows_disallowed)
   * [javascript_access_clipboard_disallowed](#javascript_access_clipboard_disallowed)
   * [local_storage_disabled](#local_storage_disabled)
@@ -117,11 +116,6 @@ Description from upstream CEF:
 (bool) Controls whether Javascript can be executed. Also configurable using the --disable-javascript switch.
 
 
-### javascript_open_windows_disallowed
-
-(bool) Controls whether Javascript can be used for opening windows. Also configurable using the --disable-javascript-open-windows switch.
-
-
 ### javascript_close_windows_disallowed
 
 (bool) Controls whether JavaScript can be used to close windows that were not

docs/Migration-guide.md

@@ -41,6 +41,7 @@ Table of contents:
 * [v66+ LifespanHandler.OnBeforePopup is now called on UI thread](#v66-lifespanhandleronbeforepopup-is-now-called-on-ui-thread)
 * [v66+ RequestHandler.OnBeforeBrowse has a new param 'user_gesture'](#v66-requesthandleronbeforebrowse-has-a-new-param-user_gesture)
 * [v66+ Window transparency changes](#v66-window-transparency-changes)
+* [v66+ BrowserSettings.javascript_open_windows_disallowed option was removed](#v66-browsersettingsjavascript_open_windows_disallowed-option-was-removed)
 
 
 
@@ -344,3 +345,9 @@ in exception**.
 transparent windows also in **windowed mode**. This seems to be working
 only on Linux (got it working on Fedora with just a change in window setting).
 
+
+## v66+ BrowserSettings.javascript_open_windows_disallowed option was removed
+
+The BrowserSettings.`javascript_open_windows_disallowed` option was removed
+(setting it will do nothing).
+

src/cef_v59..v66_changes.txt

@@ -43,9 +43,9 @@ BREAKAGE (needs updating Migration Guide doc)
   - + Update Migration Guide doc
 
 internal/cef_types.h
-- cef_settings_t:
-  - javascript_open_windows option removed (keep a dummy for BC)
-    - update Migration Guide
+- + cef_settings_t:
+  - + javascript_open_windows option removed (keep a dummy for BC)
+    - + update Migration Guide
 - cef_thread_id_t:
   - TID_DB removed (update Migration Guide)
   - TID_PROCESS_LAUNCHER removed (update Migration Guide)

src/extern/cef/cef_types.pxd

@@ -78,7 +78,6 @@ cdef extern from "include/internal/cef_types.h":
         cef_string_t default_encoding
         cef_state_t remote_fonts
         cef_state_t javascript
-        cef_state_t javascript_open_windows
         cef_state_t javascript_close_windows
         cef_state_t javascript_access_clipboard
         cef_state_t javascript_dom_paste

src/settings.pyx

@@ -191,12 +191,7 @@ cdef void SetBrowserSettings(
             else:
                 cefBrowserSettings.javascript = cef_types.STATE_ENABLED
         elif key == "javascript_open_windows_disallowed":
-            if browserSettings[key]:
-                cefBrowserSettings.javascript_open_windows = (
-                        cef_types.STATE_DISABLED)
-            else:
-                cefBrowserSettings.javascript_open_windows = (
-                        cef_types.STATE_ENABLED)
+            Debug("DEPRECATED: 'javascript_open_windows_disallowed' setting")
         elif key == "javascript_close_windows_disallowed":
             if browserSettings[key]:
                 cefBrowserSettings.javascript_close_windows = (