Changes to support IE 11 #75
Conversation
|
Thanks for the PR. This might be a good approach in the short-term. Or the readme could be updated to say that a polyfill, like babel-polyfill is required if pre-ES6 browsers are used. It's probably not practical in the long-term to keep adding internal workarounds for old browsers, especially when most client projects would be using Babel anyway. I would hope that eventually things like HashSet would be removed entirely to just use Set and simplify the extension. @ugurdogrusoz What is your opinion? |
|
Changes in data structures often have a huge impact on the performance. I don't think we should try to support old browser versions. |
…ers are unsupported Ref cytoscape#75
* Ignore node_modules in gh-pages * Add shims to the demos and adds a notice to the readme that old browsers are unsupported Ref #75
|
PR #77 addresses the demo without making changes to the extension itself. As Ugur mentioned, this extension probably won't be able to support old browsers without polyfills. @ugurdogrusoz @hasanbalci It may make sense to mention in the readme that old browsers are unsupported without polyfills. We could link to core-js as an example polyfill that could be used. |
|
@hasanbalci Can we please put a small note in the README about not supporting older browsers as Max suggested? |
|
@ugurdogrusoz Actually, a note currently exists in the README of the unstable branch. So, I think we can close this pull request. |
-replace usage of Set with HashSet to support IE 11
-add implementation of Array.from() to support IE11