Dm safe #3
Open
Dm safe #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 7, 2021 23:04
Documentation states that Reply super classes should be able to accept a Callable and the Callable will recieve the reply object. Currently the Callable does not recieve the reply object.
Because ReactionAddReply uses message.remove_reaction() and message.clear_reactions(), they cannot be used in direct messages. This PR separates ReactionAddReply into two classes DirectMessageReactionAddReply(ReactionAddBasic) which takes on_reply_init and reply_check ReactionAddReply(DirectMessageReactionAddReply) which adds on_reply_attempt and on_reply_complete ---- Having a class that works by default with DM's seems like a fairly common use case.
|
This is helpful! May I suggest, instead of separating a DM safe variant into it's own class, adding try/except or if statements? For example:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the ReactionAddReply class in a way that provides 2 classes, one with the full previous functionality and one that is safe to use in Direct Messages with more limited permissions!