-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extra spacing below project nav #7024
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
- use flexbox to make nav respond better to different heights instead of using magic number - ensure browsers have same heights so changing them doesn't change height of navbar and doesn't cause icons/text to shift
I found that switching to Firefox (with the beta tag) caused the spacing to reappear. I updated the CSS to make the nav bar items more flexible in case the navbar height changes again. I also made sure the browsers in the dropdown are a consistent height, because otherwise changing between them causes the height change, making the text shift, which is somewhat jarring. Edit: Also added a percy snapshot test for when a beta browser is displayed. |
User facing changelog
Additional details
How has the user experience changed?
Before
After
PR Tasks