Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra spacing below project nav #7024

Merged
merged 6 commits into from
Apr 17, 2020
Merged

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Apr 16, 2020

User facing changelog

  • We fixed some extra spacing displaying below the project nav in the Test Runner.

Additional details

  • I added a percy snapshot test

How has the user experience changed?

Before

Screen Shot 2020-04-15 at 10 18 01 PM

After

Screen Shot 2020-04-16 at 12 34 02 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 16, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

cypress bot commented Apr 16, 2020



Test summary

7179 1 98 0


Run details

Project cypress
Status Failed
Commit f4653e0
Started Apr 16, 2020 2:46 PM
Ended Apr 16, 2020 2:53 PM
Duration 06:29 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

cypress/integration/e2e/focus_blur_spec.js Failed
1 intercept blur methods correctly > focus

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

- use flexbox to make nav respond better to different heights instead of using magic number
- ensure browsers have same heights so changing them doesn't change height of navbar and doesn't cause icons/text to shift
@chrisbreiding
Copy link
Contributor

chrisbreiding commented Apr 16, 2020

I found that switching to Firefox (with the beta tag) caused the spacing to reappear.

Screen Shot 2020-04-16 at 10 05 16 AM

I updated the CSS to make the nav bar items more flexible in case the navbar height changes again. I also made sure the browsers in the dropdown are a consistent height, because otherwise changing between them causes the height change, making the text shift, which is somewhat jarring.

Edit: Also added a percy snapshot test for when a beta browser is displayed.

@jennifer-shehane jennifer-shehane merged commit ae5ae1f into develop Apr 17, 2020
@chrisbreiding chrisbreiding deleted the issue-7023-css-space branch April 5, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra css spacing below Desktop GUI menu
2 participants