Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove coveralls dep - not used anymore #4138

Merged
merged 3 commits into from
Jun 12, 2019
Merged

remove coveralls dep - not used anymore #4138

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66439b6
remove coveralls dep - not used anymore
jennifer-shehane May 6, 2019
dbd02ab
Merge branch 'develop' into remove-coveralls
jennifer-shehane Jun 11, 2019
13ae412
remove trailing comma in package
jennifer-shehane Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"test-e2e-chrome": "node ./test/scripts/run.js test/e2e chrome",
"test-cov": "NODE_COVERAGE=true NODE_ENV=test CYPRESS_ENV=test BLUEBIRD_DEBUG=1 xvfb-maybe istanbul cover node_modules/.bin/_mocha -- --opts ./test/support/mocha.opts",
"test-cov-process": "NODE_COVERAGE=true NODE_ENV=test CYPRESS_ENV=test BLUEBIRD_DEBUG=1 istanbul cover --include-pid",
"coveralls": "cat ./coverage/lcov.info | coveralls",
"codecov": "codecov",
"lint": "bin-up coffeelint test/*.coffee test/unit/*.coffee test/integration/*.coffee",
"prestart": "npm run check-deps-pre",
"predev": "npm run check-deps-pre",
Expand All @@ -38,7 +38,7 @@
"pretest-e2e-chrome": "npm run check-deps-pre",
"pretest-cov": "npm run check-deps-pre",
"pretest-cov-process": "npm run check-deps-pre",
"precoveralls": "npm run check-deps-pre"
"precodecov": "npm run check-deps-pre",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is your problem - trailing comma here

},
"files": [
"config",
Expand Down Expand Up @@ -66,7 +66,6 @@
"coffee-coverage": "1.0.1",
"console-table-printer": "1.0.0-beta12",
"cors": "2.8.5",
"coveralls": "2.13.3",
"electron-osx-sign": "0.4.11",
"eol": "0.9.1",
"eventsource": "1.0.7",
Expand Down