Run tests against Chrome 73, Node 8.2.1 #3891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa1d52b.
|
@bkucera can you take a look at the failing driver integration tests? Seems like something in Chrome 73 could be breaking |
bahmutov
changed the title
|
Weirdly enough, It's some other tests that are failing. |
flotwig
changed the title
|
Superseded by #4001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Circle config to use
cypress/browsers:node8.21-chrome73.This PR also re-enables the HTTPS performance tests, now that
--disable-http2is available as a Chrome arg so they'll work.