Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where scrollbar would take up full width of test runner instead of only command log in Chrome 72+ #3255

Merged
merged 4 commits into from
Jan 30, 2019

Conversation

jennifer-shehane
Copy link
Member

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks to be breaking the UI:

screen shot 2019-01-30 at 2 00 12 pm

The long lines widen the reporter and the overflow ends up hidden.

It also messes with the responsive design (look at the controls in the top left):

reporter-responsive-broken

This is what it should do:

reporter-responsive-normal

use position: absolute to make it full height instead of flex-box
@brian-mann brian-mann merged commit d54165b into develop Jan 30, 2019
@chrisbreiding chrisbreiding deleted the issue-3253 branch February 6, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome 72 - Scrollbar for Test Runner aligns with AUT instead of Command Log
3 participants