chore: make sure the constant for the welcome screen is patched #30893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
approved these changes
Jan 16, 2025
mschile
approved these changes
Jan 16, 2025
ryanthemanuel
approved these changes
Jan 16, 2025
AtofStryker
force-pushed
the
chore/patch_welcome_screen
branch
from
8443a5e to
db2e18c
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/patch_welcome_screen
|
| Run status |
|
| Run duration | 11m 29s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
892
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.52%
|
|
|---|---|
|
Untested elements
|
144
|
|
Tested elements
|
127
|
Accessibility
92.07%
|
|
|---|---|
|
Failed rules
|
3 critical
7 serious
2 moderate
1 minor
|
|
Failed elements
|
723
|
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
There is a bug in the welcome screen code where the welcome screen is not being shown because the
MAJOR_VERSION_FOR_CONTENTwas not set in #30845.The goal here is to merge this in and publish this binary as
14.0.0in the Cypress CDN as the package is still currently in dev modeSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?