-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Cleanup duplication across tsconfig files in packages #30764
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,7 @@ | ||
{ | ||
"extends": "../ts/tsconfig.json", | ||
"compilerOptions": { | ||
"target": "es2015", | ||
"module": "commonjs", | ||
"allowJs": true, | ||
"allowSyntheticDefaultImports": true, | ||
"esModuleInterop": true, | ||
"noImplicitAny": false, | ||
"importHelpers": true, | ||
"strict": false | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,55 +1,12 @@ | ||
{ | ||
"extends": "../ts/tsconfig.json", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. newly extended |
||
"compilerOptions": { | ||
/* Basic Options */ | ||
"target": "ES2018", | ||
"module": "esnext", | ||
"lib": ["dom", "ESNext"], | ||
/* | ||
* Allow javascript files to be compiled. | ||
* Override this in modules that need JS | ||
*/ | ||
"noEmit": true, | ||
"jsx": "preserve", | ||
"preserveWatchOutput": true, | ||
// "checkJs": true, /* Report errors in .js files. */ | ||
// "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ | ||
/* Generates corresponding '.d.ts' file. */ | ||
// "declaration": true, | ||
// "declarationMap": true, /* Generates a sourcemap for each corresponding '.d.ts' file. */ | ||
/* Generates corresponding '.map' file. */ | ||
"sourceMap": true, | ||
/* Import emit helpers from 'tslib'. */ | ||
"importHelpers": true, | ||
"strictNullChecks": true, | ||
// "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ | ||
// "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ | ||
/* Strict Type-Checking Options */ | ||
// "traceResolution": true, | ||
"strict": true, | ||
"noImplicitAny": false, | ||
"noImplicitThis": false, | ||
"forceConsistentCasingInFileNames": true, | ||
/** | ||
* Skip type checking of all declaration files (*.d.ts). | ||
* TODO: Look into changing this in the future | ||
*/ | ||
/* Additional Checks */ | ||
"skipLibCheck": true, | ||
/* Report errors on unused locals. */ | ||
// "noEmit": true, | ||
"noUnusedLocals": false, | ||
// "noUnusedParameters": true, /* Report errors on unused parameters. */ | ||
/* Report error when not all code paths in function return a value. */ | ||
"noImplicitReturns": true, | ||
// "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ | ||
/* Module Resolution Options */ | ||
"moduleResolution": "node", /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */ | ||
// "baseUrl": "./", /* Base directory to resolve non-absolute module names. */ | ||
// "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */ | ||
// "rootDirs": ["../driver/src"], /* List of root folders whose combined content represents the structure of the project at runtime. */ | ||
// "typeRoots": [] /* List of folders to include type definitions from. */ | ||
|
||
/* Type declaration files to be included in compilation. */ | ||
"noErrorTruncation": true, | ||
"paths": { | ||
"@cy/i18n": ["../frontend-shared/src/locales/i18n"], | ||
"@cy/components/*": ["../frontend-shared/src/components/*"] | ||
|
@@ -63,17 +20,5 @@ | |
"cypress-real-events", | ||
"cypress" | ||
], | ||
"allowSyntheticDefaultImports": true, | ||
"esModuleInterop": true, | ||
"noErrorTruncation": true, | ||
"experimentalDecorators": true, | ||
"resolveJsonModule": true, | ||
"ignoreDeprecations": "5.0", | ||
/* | ||
* TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior | ||
* as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module. | ||
*/ | ||
"importsNotUsedAsValues": "error", | ||
"useUnknownInCatchVariables": false | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,8 @@ | ||
{ | ||
"extends": "../ts/tsconfig.json", | ||
"compilerOptions": { | ||
"strict": true, | ||
"allowJs": false, | ||
"noImplicitAny": true, | ||
"noUnusedLocals": false, | ||
"resolveJsonModule": true, | ||
"experimentalDecorators": true, | ||
"noUncheckedIndexedAccess": true, | ||
"ignoreDeprecations": "5.0", | ||
/* | ||
* TODO: remove importsNotUsedAsValues after typescript 5.5 and up as it will no longer work. If we want the same behavior | ||
* as importsNotUsedAsValues, we need to use "verbatimModuleSyntax", which will require this package to be an ES Module. | ||
*/ | ||
"importsNotUsedAsValues": "error", | ||
"outDir": "dist", | ||
"declaration": true | ||
}, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,6 @@ | |
"./index.ts" | ||
], | ||
"compilerOptions": { | ||
"skipLibCheck": true | ||
}, | ||
"files": [ | ||
"./../ts/index.d.ts" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newly extended