test: fix issue with electron in service-worker.cy.js #29089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 flaky tests on run #54428 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #29089 ↗︎
AtofStryker
approved these changes
Mar 8, 2024
| cy.log('Skipping fetch handlers validation in non-Chromium browsers') | ||
| // skip validation in non-Chromium and electron browsers | ||
| // non-Chromium browsers do not fully support the remote debugger protocol | ||
| // possibly remove the electron check on https://github.com/cypress-io/cypress/issues/2118 is resolved |
There was a problem hiding this comment.
Suggested change
| // possibly remove the electron check on https://github.com/cypress-io/cypress/issues/2118 is resolved | |
| // possibly remove the electron check once https://github.com/cypress-io/cypress/issues/2118 is resolved |
cacieprins
approved these changes
Mar 11, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
If the
abort_beforeunload_event_child.cy.tsspec runs before theservice-worker.cy.tsspec, thegetEventListeners(self).fetchcommand may returnundefinedinstead of the actual listeners. Possibly related to #2118. Theabort_beforeunload_event_childspec is currently always run before theservice-workerspec for contributor PRs which is why they are currently failing. We are going to skip thevalidateFetchHandlersinelectrondue to this issue. The check is really secondary and the test will still fail if the correlation timeout is hit.Verified this is NOT a new issue by running the
service-worker.cy.jstest againstv13.6.2(which is prior to when we added any of the service worker logic) and observing the same 8 test failures.Steps to test
See successful contributor PR run.
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?