Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync currentRetry state with secondary origin #28651

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

emilyrohrbough
Copy link
Member

Before After
Screen Shot 2023-12-21 at 4 23 34 PMScreen Shot 2023-12-21 at 4 18 56 PM Screen Shot 2024-01-05 at 3 14 28 PM

PR Tasks

@AtofStryker AtofStryker self-requested a review January 8, 2024 14:39
Co-authored-by: Bill Glesias <[email protected]>
@emilyrohrbough emilyrohrbough merged commit c9592bf into develop Jan 10, 2024
5 checks passed
@emilyrohrbough emilyrohrbough deleted the em/origin-retries branch January 10, 2024 19:49
Copy link

cypress bot commented Jan 10, 2024

6 flaky tests on run #53394 ↗︎

0 5506 79 0 Flakiness 6

Details:

Update cli/CHANGELOG.md
Project: cypress Commit: c5bceef19d
Status: Passed Duration: 14:38 💡
Started: Jan 10, 2024 7:39 PM Ended: Jan 10, 2024 7:53 PM
Flakiness  e2e/origin/origin.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin > withBeforeEach > passes runnable state to the secondary origin on retry Test Replay
Flakiness  commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
src/cy/commands/storage > #getAllLocalStorage > gets local storage from all origins Test Replay
Flakiness  e2e/origin/commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin storage > .getAllLocalStorage Test Replay
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome

View Output

Test Artifacts
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay
... > correctly returns currentRetry Test Replay

Review all test suite changes for PR #28651 ↗︎

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 17, 2024

Released in 13.6.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secondary Origin Logs are not Shown in the Reporter on Retries
3 participants