Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add guided error for removal of videoUploadOnPasses config option #27158

Conversation

AtofStryker
Copy link
Contributor

  • Closes N/A

Additional details

When implementing #27010, I forgot to add the warning for the videoUploadOnPasses config to point users to the migration guide. This PR adds that warning.

Screenshot 2023-06-28 at 2 57 14 PM

Steps to test

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Jun 30, 2023

4 flaky tests on run #48508 ↗︎

0 5320 81 0 Flakiness 4

Details:

Merge branch 'release/13.0.0' into chore/implemented_guided_videoUploadOnPasses_...
Project: cypress Commit: 1ff150a44f
Status: Passed Duration: 14:14 💡
Started: Jun 30, 2023 4:58 PM Ended: Jun 30, 2023 5:13 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output Video

Test Artifacts
... > stops waiting when an fetch request is canceled Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@AtofStryker AtofStryker merged commit d3200df into release/13.0.0 Jun 30, 2023
@AtofStryker AtofStryker deleted the chore/implemented_guided_videoUploadOnPasses_removal_config branch June 30, 2023 17:17
@cypress cypress bot mentioned this pull request Jun 30, 2023
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants