Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UNIFY-676 browsers should be configurable in setupNodeEvents #20367

Merged
merged 10 commits into from
Mar 1, 2022
+46 −25
Merged

fix: UNIFY-676 browsers should be configurable in setupNodeEvents #20367

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
04723da
fix: Add test for UNIFY-676
tgriesser Feb 25, 2022
ca0a01f
Update packages/types/src/browser.ts
tgriesser Feb 25, 2022
116061d
Merge branch '10.0-release' into tgriesser/fix/UNIFY-676
Feb 25, 2022
2b005eb
fixes to types, failing test
tgriesser Feb 25, 2022
2c8b6ff
Merge remote-tracking branch 'origin/10.0-release' into tgriesser/fix…
lmiller1990 Feb 28, 2022
97ba5cf
chore: fix typing errors
lmiller1990 Feb 28, 2022
a52cd83
Merge remote-tracking branch 'origin/10.0-release' into tgriesser/fix…
lmiller1990 Feb 28, 2022
2e40041
Revert "chore: fix typing errors"
tgriesser Feb 28, 2022
ce158b0
fix: for browsers field, fix types
tgriesser Feb 28, 2022
da6eca1
Merge branch '10.0-release' into tgriesser/fix/UNIFY-676
tgriesser Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/launchpad/cypress/e2e/system-tests/config-spec.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
describe('config-spec', () => {
it('can filter browsers from config', () => {
cy.scaffoldProject('plugin-filter-browsers')
cy.findBrowsers()
cy.openProject('plugin-filter-browsers', ['--e2e'])
cy.withCtx(async (ctx) => {
expect(await ctx.browser.machineBrowsers()).to.have.length(12) // stubbed list of all browsers
})

cy.visitLaunchpad()
// Filtered down to the electron browser in the plugin
cy.get('[data-cy="open-browser-list"]').children().should('have.length', 1)
})
})