Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cy.then shows wrong type when raw HTMLElement is provided. #15624

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Mar 23, 2021

User facing changelog

cy.then will show correct type when raw HTMLElements are provided.

Additional details

  • Why was this change necessary? => When a raw HTMLElement is return from the previous cy.then, it is automatically wrapped with JQuery, but this behavior was not reflected in the function type.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => Added new definition for the function.

How has the user experience changed?

N/A

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 23, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh changed the title fix: cy.then wrong type when raw HTMLElement is provided. fix: cy.then shows wrong type when raw HTMLElement is provided. Mar 23, 2021
@sainthkh sainthkh marked this pull request as ready for review March 23, 2021 02:30
@sainthkh
Copy link
Contributor Author

Flaky failures.

@jennifer-shehane
Copy link
Member

Thanks! Definitely unexpected with the types being incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation and types do not reflect behaviour of then when returning element
3 participants