Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking config changes #1754

Closed
brian-mann opened this issue May 22, 2018 · 3 comments
Closed

Breaking config changes #1754

brian-mann opened this issue May 22, 2018 · 3 comments
Assignees
@brian-mann
Labels
type: enhancement Requested enhancement of existing feature
Milestone
3.0.0

Comments

@brian-mann
Copy link
Member

brian-mann commented May 22, 2018 •
edited
Loading

We are no longer distinguishing between headless per this issue: #1140

To synchronize the nomenclature changes we've done the following:

  • screenshotOnHeadlessFailures has been removed in favor of the new Screenshot options exclusively in the driver
  • trashAssetsBeforeHeadlessRuns -> trashAssetsBeforeRuns
  • videoRecording -> video

We will throw an explicit error if using the old verbiage.
@brian-mann brian-mann added the type: enhancement Requested enhancement of existing feature label May 22, 2018
@brian-mann brian-mann added this to the 3.0.0 milestone May 22, 2018
@brian-mann brian-mann self-assigned this May 22, 2018
@brian-mann
Copy link
Member Author

screen shot 2018-05-27 at 11 32 13 pm

@brian-mann
Copy link
Member Author

screen shot 2018-05-27 at 11 35 26 pm

brian-mann added a commit that referenced this issue May 28, 2018
@brian-mann
fixes #1754 remove screenshotOnHeadlessFailure and rename trashAssets…
84f7c3a 
…BeforeHeadlessRuns
@brian-mann
Copy link
Member Author

Released in 3.0.0.

This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@brian-mann @jennifer-shehane