Skip to content

Commit

Permalink
fix undefined channel for browsers launched via gui
Browse files Browse the repository at this point in the history
  • Loading branch information
flotwig committed Feb 6, 2020
1 parent 1405588 commit 4139607
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ describe('Project Nav', function () {
const browserArg = this.ipc.launchBrowser.getCall(0).args[0].browser

expect(browserArg).to.have.keys([
'family', 'name', 'path', 'version', 'majorVersion', 'displayName', 'info', 'isChosen', 'custom', 'warning',
'family', 'name', 'path', 'version', 'majorVersion', 'displayName', 'info', 'isChosen', 'custom', 'warning', 'channel',
])

expect(browserArg.path).to.include('/')
Expand Down
2 changes: 2 additions & 0 deletions packages/desktop-gui/src/lib/browser-model.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ export default class Browser {
@observable displayName
@observable name
@observable family
@observable channel
@observable version
@observable path
@observable majorVersion
Expand All @@ -16,6 +17,7 @@ export default class Browser {
this.displayName = browser.displayName
this.name = browser.name
this.family = browser.family
this.channel = browser.channel
this.version = browser.version
this.path = browser.path
this.majorVersion = browser.majorVersion
Expand Down

1 comment on commit 4139607

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 4139607 Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

You can install this pre-release platform-specific build using instructions at https://on.cypress.io/installing-cypress#Install-pre-release-version.

You will need to use custom CYPRESS_INSTALL_BINARY url and install Cypress using an url instead of the version.

export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/3.8.4/linux-x64/circle-issue-1096-firefox-support-4139607638c05ede783517a374bbbd0b9c03f0da-246970/cypress.zip
npm install https://cdn.cypress.io/beta/npm/3.8.4/circle-issue-1096-firefox-support-4139607638c05ede783517a374bbbd0b9c03f0da-246958/cypress.tgz

Please sign in to comment.