Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(net-stubbing): rename cy.route2 to cy.http #3322

Merged
merged 3 commits into from
Nov 14, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Nov 12, 2020

DO NOT MERGE UNTIL cypress-io/cypress#9182 IS MERGED

for cypress-io/cypress#9182

@flotwig flotwig marked this pull request as ready for review November 12, 2020 17:12
Comment on lines 479 to +480
* {% url "`cy.route2()` example recipes with real-world examples" https://github.com/cypress-io/cypress-example-recipes#stubbing-and-spying %}
* {% url "`cy.route` vs `cy.route2`" https://glebbahmutov.com/blog/cy-route-vs-route2/ %} blog post
* {% url "`cy.route()` vs `cy.route2()`" https://glebbahmutov.com/blog/cy-route-vs-route2/ %} blog post
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links will need to be updated to newer http recipe + blog. Not blocking this PR necessarily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, i was thinking incremental updates here

@jennifer-shehane jennifer-shehane mentioned this pull request Nov 13, 2020
11 tasks
@jennifer-shehane jennifer-shehane merged commit 1e466a2 into 6.0.0-release Nov 14, 2020
@matthamil matthamil deleted the cy.route2-to-cy.http branch April 14, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants