add edge to the list of browsers (#2416)

* add edge to the list of browsers * Add edge to launching-browsers list / remove 'new' mention (this will become outdated) Co-authored-by: Jennifer Shehane <[email protected]>
cypress-io · Jan 28, 2020 · a21d475 · a21d475
1 parent f5af1c6
commit a21d475
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/source/api/plugins/browser-launch-api.md b/source/api/plugins/browser-launch-api.md
@@ -20,7 +20,7 @@ This event will yield you the `browser` as an object, and `args` which are the d
 
 Here are options for the currently supported browsers:
 
-* {% url 'Chrome, Chromium, or Canary' "https://peter.sh/experiments/chromium-command-line-switches/" %}
+* {% url 'Chrome, Chromium, Chrome Canary, or Microsoft Edge' "https://peter.sh/experiments/chromium-command-line-switches/" %}
 * {% url 'Electron' "https://github.com/electron/electron/blob/master/docs/api/browser-window.md#new-browserwindowoptions" %}
 
 ```js

diff --git a/source/guides/guides/command-line.md b/source/guides/guides/command-line.md
@@ -105,7 +105,7 @@ Option | Description
 cypress run --browser chrome
 ```
 
-The "browser" argument can be set to "chrome", "canary", "chromium", or "electron" to launch a browser detected on your system. Cypress will attempt to automatically find the installed browser for you.
+The "browser" argument can be set to "chrome", "canary", "chromium", "edge", "edgeCanary" or "electron" to launch a browser detected on your system. Cypress will attempt to automatically find the installed browser for you.
 
 You can also choose a browser by supplying a path:
 
@@ -325,7 +325,7 @@ Give a run multiple tags.
 cypress run --record --tag "production,nightly"
 ```
 
-The Dashboard will display any tags sent with the appropriate run. 
+The Dashboard will display any tags sent with the appropriate run.
 
 {% imgTag /img/dashboard/dashboard-run-with-tags.png "Cypress run in the Dashboard displaying flags" %}
 
@@ -365,7 +365,7 @@ cypress open --browser /usr/bin/chromium
 
 If found, the specified browser will be added to the list of available browsers in the Cypress Test Runner.
 
-Currently, only browsers in the Chrome family are supported.
+Currently, only browsers in the Chrome family are supported (including the new Chromium-based Microsoft Edge and Brave).
 
 {% url "Having trouble launching a browser? Check out the debugging guide" debugging#Launching-browsers %}
 

diff --git a/source/guides/guides/debugging.md b/source/guides/guides/debugging.md
@@ -160,6 +160,8 @@ Browser Name | Expected Bundle Identifier | Expected Executable
 `chromium` | `org.chromium.Chromium` | `Contents/MacOS/Chromium`
 `canary` | `com.google.Chrome.canary` | `Contents/MacOS/Google Chrome Canary`
 
+For the current list, see {% url 'packages/launcher' https://github.com/cypress-io/cypress/blob/develop/packages/launcher/lib/darwin/index.ts %} files.
+
 ### Linux
 
 On Linux, Cypress scans your `PATH` for a number of different binary names. If the browser you are trying to use does not exist under one of the expected binary names, Cypress will not be able to find it.
@@ -188,6 +190,8 @@ Browser Name | Expected Path
 `chromium` | `C:/Program Files (x86)/Google/chrome-win32/chrome.exe`
 `canary` | `%APPDATA%/../Local/Google/Chrome SxS/Application/chrome.exe`
 
+For the current list, see {% url 'packages/launcher' https://github.com/cypress-io/cypress/blob/develop/packages/launcher/lib/windows/index.ts %} files.
+
 To make a browser installed at a different path be auto-detected, create a symbolic link using `mklink` in the location that Cypress expects to find your browser.
 
 {% url 'Read more about creating symbolic links on Windows' https://www.howtogeek.com/howto/16226/complete-guide-to-symbolic-links-symlinks-on-windows-or-linux/ %}

diff --git a/source/guides/guides/launching-browsers.md b/source/guides/guides/launching-browsers.md
@@ -14,6 +14,7 @@ When Cypress is initially run from the Test Runner, you can choose to run Cypres
 - {% url "Canary" https://www.google.com/chrome/browser/canary.html %}
 - {% url "Chrome" https://www.google.com/chrome/browser/desktop/index.html %}
 - {% url "Chromium" https://www.chromium.org/Home %}
+- {% url "Edge" https://www.microsoft.com/edge %}
 - {% url "Electron" https://electron.atom.io/ %}
 
 Cypress automatically detects available browsers on your OS. You can switch the browser in the Test Runner by using the drop down in the top right corner:
@@ -64,6 +65,12 @@ Or Chrome Canary:
 cypress run --browser canary
 ```
 
+Or Microsoft Edge:
+
+```shell
+cypress run --browser edge
+```
+
 {% url 'Having issues launching installed browsers? Read more about debugging browser launching' debugging#Launching-browsers %}
 
 ## Launching by a path