Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added buildable instructions for Rivanna #643

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

arupcsedu
Copy link
Collaborator

Signed-off-by: Arup Sarker [email protected]

Added all blue packages to overcome the dependencies on the preloaded modules.

```shell
conda env create -f conda/environments/cylon.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify a Python version for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need it. Rivanna's default python version works perfectly.

@vibhatha
Copy link
Collaborator

@arupcsedu Thanks for working on this. I have externally looked at this. Sorry about my lack of knowledge about the context of the PR. It would be better to include a good description in the PR to give some clarity on what the feature is introducing. And later on when we run into issues, we could rely on this description and debug.

I assume this is a platform or compute resource where we want to setup Cylon. Please correct me if I am wrong.

Overall the PR looks good to me in external shape, but I haven't and don't know how to test the instructions to see if they function properly.

Is there a way to include a CI to Cylon to run this with the said platform/resources? If not, it would be better to keep an isolated/internal workload which can test this.

Would it be wise to include a docker or a singularity image which could be deployed quite easily?

@laszewsk
Copy link
Collaborator

laszewsk commented Feb 13, 2023

  • docker is not available in rivanna
  • my experience from using docker to singularity to rivanna is miserable due to very slow upload times.
  • singularity has very limited images available on rivanna from my experience it is best to have modified requirements such as the one discussed here.
  • As the setup Is so complex, it is advisable to distribute it so that it can also serve as an example for others.
  • Maybe you want to give all platforms a special directory as I imagine this could be an issue for others.
  • one issue for the adaption of Cylon is platform differences. please remember we have a similar issue for summit.

The conclusion I have is that each platform needs a special documentation so that others do not spend hours, days, or weeks for the deployment and they can learn from each other

@nirandaperera nirandaperera merged commit d1739ed into cylondata:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants