-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added buildable instructions for Rivanna #643
Conversation
Signed-off-by: Arup Sarker <[email protected]>
Signed-off-by: Arup Sarker <[email protected]>
Added all blue packages to overcome the dependencies on the preloaded modules. | ||
|
||
```shell | ||
conda env create -f conda/environments/cylon.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we specify a Python
version for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need it. Rivanna's default python version works perfectly.
@arupcsedu Thanks for working on this. I have externally looked at this. Sorry about my lack of knowledge about the context of the PR. It would be better to include a good description in the PR to give some clarity on what the feature is introducing. And later on when we run into issues, we could rely on this description and debug. I assume this is a platform or compute resource where we want to setup Cylon. Please correct me if I am wrong. Overall the PR looks good to me in external shape, but I haven't and don't know how to test the instructions to see if they function properly. Is there a way to include a CI to Cylon to run this with the said platform/resources? If not, it would be better to keep an isolated/internal workload which can test this. Would it be wise to include a docker or a singularity image which could be deployed quite easily? |
The conclusion I have is that each platform needs a special documentation so that others do not spend hours, days, or weeks for the deployment and they can learn from each other |
Signed-off-by: Arup Sarker [email protected]