Fixing: Corrupted result when joining tables contain list data types #615 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstaylor
added a commit
to mstaylor/cylon
that referenced
this pull request
Aug 31, 2022
…te::Take and pass corresponding indices to it - changes from build to using std:vector and std:sort. Vector data is moved to an arrow::Buffer::Wrap (wrapper) that can be used by the actual arrow::Array (continued - adds call to WrapNumericVector function added by cylondata#615-cylondata#616)
nirandaperera
added a commit
that referenced
this pull request
Sep 29, 2022
#612) * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it. Note: 1)Commented code that was deprecated by the resolution of this issue 2) Note comments in sample_binary_array function related to result status. * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it - partial * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it - changes from PR review * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it - changes from build to using std:vector and std:sort. Vector data is moved to an arrow::Buffer::Wrap (wrapper) that can be used by the actual arrow::Array. * #610: SampleArray util method replaced by using arrow::compute::Take and pass corresponding indices to it - changes from build to using std:vector and std:sort. Vector data is moved to an arrow::Buffer::Wrap (wrapper) that can be used by the actual arrow::Array (continued - adds call to WrapNumericVector function added by #615-#616) * #610: move SampleTableUniform to arrow_utils and reflect changes to table.cpp * #610: correctly use reserve in vector to prevent reallocations and remove the incorrect initialization in the constructor. * #610: changes SampleTableUniform to arrow datatypes versus cylon * #610: Implements requests change to address SIG Faults. Also applied google formatter per PR request. Validated tests complete successfully. * Update arrow_utils.cpp * Update arrow_utils.hpp Co-authored-by: niranda perera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.