-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gloo python bindings #585
Gloo python bindings #585
Conversation
python/pycylon/setup.py
Outdated
cython_files = ['pycylon/net/channel.pyx', | ||
'pycylon/net/comm_type.pyx', | ||
'pycylon/net/communicator.pyx', | ||
'pycylon/net/comm_config.pyx', | ||
'pycylon/net/mpi_config.pyx', | ||
'pycylon/net/txrequest.pyx', | ||
'pycylon/net/comm_ops.pyx', | ||
'pycylon/_libs/index.pyx', | ||
'pycylon/data/scalar.pyx', | ||
'pycylon/data/groupby.pyx', | ||
'pycylon/data/arrow_util.pyx', | ||
'pycylon/data/aggregates.pyx', | ||
'pycylon/data/column.pyx', | ||
'pycylon/data/csv.pyx', | ||
'pycylon/data/compute.pyx', | ||
'pycylon/data/table.pyx', | ||
'pycylon/data/data_type.pyx', | ||
'pycylon/api/lib.pyx', | ||
'pycylon/api/types.pyx', | ||
'pycylon/indexing/cyindex.pyx', | ||
'pycylon/indexing/index_utils.pyx', | ||
'pycylon/ctx/context.pyx', | ||
'pycylon/io/csv_write_config.pyx', | ||
'pycylon/io/csv_read_config.pyx', | ||
'pycylon/common/status.pyx', | ||
'pycylon/common/join_config.pyx', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay. We can modularize it later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pycylon/data/**
, pycylon/api./**
something like this, but I am not sure, what is the best way to capture the modularized ones. But the existing one is satisfactory for the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT
@vibhatha this works well in my machine. I dont understand how these changes would affect the runtime path. 🙁 |
@nirandaperera seems CIs are failing. |
you mean the changes I suggested? Or the changes we did to include Gloo? |
So, in my local machine, I can get these changes to work without a problem. But somehow, in CI, its failing |
It’s failing unfortunately. I will take a closer look. |
No description provided.