Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gloo python bindings #585

Merged
merged 17 commits into from
May 20, 2022
Merged

Conversation

nirandaperera
Copy link
Collaborator

No description provided.

Comment on lines 59 to 84
cython_files = ['pycylon/net/channel.pyx',
'pycylon/net/comm_type.pyx',
'pycylon/net/communicator.pyx',
'pycylon/net/comm_config.pyx',
'pycylon/net/mpi_config.pyx',
'pycylon/net/txrequest.pyx',
'pycylon/net/comm_ops.pyx',
'pycylon/_libs/index.pyx',
'pycylon/data/scalar.pyx',
'pycylon/data/groupby.pyx',
'pycylon/data/arrow_util.pyx',
'pycylon/data/aggregates.pyx',
'pycylon/data/column.pyx',
'pycylon/data/csv.pyx',
'pycylon/data/compute.pyx',
'pycylon/data/table.pyx',
'pycylon/data/data_type.pyx',
'pycylon/api/lib.pyx',
'pycylon/api/types.pyx',
'pycylon/indexing/cyindex.pyx',
'pycylon/indexing/index_utils.pyx',
'pycylon/ctx/context.pyx',
'pycylon/io/csv_write_config.pyx',
'pycylon/io/csv_read_config.pyx',
'pycylon/common/status.pyx',
'pycylon/common/join_config.pyx',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay. We can modularize it later on.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pycylon/data/**, pycylon/api./** something like this, but I am not sure, what is the best way to capture the modularized ones. But the existing one is satisfactory for the moment.

Copy link
Collaborator

@vibhatha vibhatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT

@nirandaperera
Copy link
Collaborator Author

@vibhatha this works well in my machine. I dont understand how these changes would affect the runtime path. 🙁

@vibhatha
Copy link
Collaborator

@nirandaperera seems CIs are failing.

@vibhatha
Copy link
Collaborator

@vibhatha this works well in my machine. I dont understand how these changes would affect the runtime path. 🙁

you mean the changes I suggested? Or the changes we did to include Gloo?

@nirandaperera
Copy link
Collaborator Author

@vibhatha this works well in my machine. I dont understand how these changes would affect the runtime path. slightly_frowning_face

you mean the changes I suggested? Or the changes we did to include Gloo?

So, in my local machine, I can get these changes to work without a problem. But somehow, in CI, its failing

@nirandaperera nirandaperera requested a review from vibhatha May 18, 2022 21:07
@vibhatha
Copy link
Collaborator

It’s failing unfortunately. I will take a closer look.

@nirandaperera nirandaperera merged commit 773f11f into cylondata:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants