Dist sort cpu #574
Merged
Dist sort cpu #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pling; add empty table test; change repartition
nirandaperera
requested changes
Mar 9, 2022
There was a problem hiding this comment.
@kaiyingshan Thank you for doing this. I noticed a couple of things.
- Please use a code formatter (we use Google style and wrapping at 100 chars) - Almost all IDEs provide this support
- We could reuse more of the comparators and util methods. I've added comments where things could be simplified using our existing methods.
Please ping me if you need any clarification.
cpp/src/cylon/table.cpp
Outdated
| SortOptions sort_options) { | ||
| return DistributedSort(table, std::vector<int>{sort_column}, output, std::vector<bool>{ascending}, | ||
| sort_options); | ||
| Status SampleTableUniform(const std::shared_ptr<Table> &local_sorted, |
There was a problem hiding this comment.
IMO this method should move to cpp/src/cylon/util/arrow_utils.hpp
ahmet-uyar
requested changes
Mar 13, 2022
ahmet-uyar
approved these changes
Mar 29, 2022
nirandaperera
requested changes
Apr 15, 2022
There was a problem hiding this comment.
@kaiyingshan I made some comments with 1 possible bug. Other that this looks good to me. Let me know if you need anything from my end.
Co-authored-by: niranda perera <[email protected]>
|
conda has introduced some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement distributed sort regular sampling, change
distributedSortdefault option to regular sampling (involves changing SortOptions)