Fixing 554 #558

nirandaperera · 2021-12-30T03:50:28Z

testing #554

nirandaperera · 2021-12-30T04:14:27Z

@kaiyingshan it seems to be failing inside conda env. This is quite strange. 🤔

nirandaperera · 2022-01-03T15:47:42Z

@kaiyingshan could you pleasw review this PR?

cpp/src/cylon/util/arrow_utils.cpp

python/pycylon/test/test_parquet.py

Co-authored-by: Kaiying Shan <[email protected]>

enabling test

049dc1c

nirandaperera requested a review from kaiyingshan December 30, 2021 03:50

nirandaperera added 6 commits December 31, 2021 12:03

extending equal testcase to distributed

03b3ea2

addig equal test to test_all

17a0e81

minor miss

69e8e67

fix equality bug

afacab5

using unordered equal operation for VERIFY_TABLE_UNORDERED

87a18b2

minor changes to python build

b07fad3

nirandaperera mentioned this pull request Jan 2, 2022

[Bug] unordered equal gives wrong result #554

Closed

fixing bug

eeb7374

nirandaperera changed the title ~~Checking 554~~ Fixing 554 Jan 2, 2022

minor

78b89c9

nirandaperera marked this pull request as ready for review January 3, 2022 00:26

kaiyingshan reviewed Jan 5, 2022

View reviewed changes

cpp/src/cylon/util/arrow_utils.cpp Outdated Show resolved Hide resolved

kaiyingshan reviewed Jan 5, 2022

View reviewed changes

python/pycylon/test/test_parquet.py Outdated Show resolved Hide resolved

Apply suggestions from code review

8fddbb6

Co-authored-by: Kaiying Shan <[email protected]>

nirandaperera merged commit 1a8c3d7 into cylondata:main Jan 5, 2022

Provide feedback