added io functions #550
Merged
added io functions #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaiyingshan I think Gregor's comment on the circular dependency is correct. We would have to take |
|
python test cases can be added for all read/write functions. |
ahmet-uyar
reviewed
Dec 26, 2021
python/pycylon/pycylon/frame.py
Outdated
| @@ -2307,6 +2345,157 @@ def applymap(self, func, na_action=None) -> DataFrame: | |||
| """ | |||
| return DataFrame(self._table.applymap(func)) | |||
|
|
|||
| @staticmethod | |||
| def read_csv(paths: Union[str, List[str], Dict[int, Union[str, List[str]]]], | |||
| env: CylonEnv, **kwargs) -> DataFrame: | |||
There was a problem hiding this comment.
documentation can be added.
python/pycylon/pycylon/frame.py
Outdated
|
|
||
| @staticmethod | ||
| def read_json(paths: Union[str, List[str], Dict[int, Union[str, List[str]]]], | ||
| env: CylonEnv, **kwargs) -> DataFrame: |
There was a problem hiding this comment.
documentation can be added.
python/pycylon/pycylon/frame.py
Outdated
|
|
||
| @staticmethod | ||
| def read_parquet(paths: Union[str, List[str], Dict[int, Union[str, List[str]]]], | ||
| env: CylonEnv, |
There was a problem hiding this comment.
documentation can be added.
|
@kaiyingshan please take a pull from the master. |
|
@kaiyingshan could you please merge master here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.