-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 404 after jupyterhub 1.0.0 #39
Conversation
And later if we keep using JupyterHub as a dependency in the ui server (there is work-in-progress that may eliminate that dependency by @MartinRyan), we can remove our implementation and simply import theirs. |
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 68.13% 67.34% -0.79%
==========================================
Files 2 2
Lines 91 98 +7
Branches 6 6
==========================================
+ Hits 62 66 +4
- Misses 29 32 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @kinow, I am too late to the game on this one as I see it has already been merged, buy FYI & for future, there is a useful Tornado decorator, @tornado.web.addslash
, which will automatically add in a /
to the URL if not present.
(I discovered it & used it in my recent work for a Rose service (PR metomi/rose#2288 if you are interested, see https://github.com/metomi/rose/blob/2dd607f6ca8ed251c2559265a9e58a7fed2fe9f0/lib/python/rosie/ws.py#L166-L168.)
This is a neat custom solution for the problem though!
I think that worked @sadielbartholomew ! Much simpler, thanks! |
Finally found a way to fix this one. Tested locally.
It worked before when the button was pointing to
/user/$USER/
with the trailing slash. Now it copies the behaviour of jupyterhub'sAddSlashHandler
.