Tableview

[giulianoserrao]

These changes partially address #631 (@hjoliver #631 will stay open after this PR is merged; we will just create more PR's against that issue as we improve the table view, or should we create separate issues?)

Requirements check-list

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Appropriate tests are included (unit and/or functional).
• Appropriate change log entry included.
• No documentation update required.

[codecov-commenter]

Codecov Report

Merging #672 (0261f38) into master (0932f42) will decrease coverage by 0.43%.
The diff coverage is 86.84%.

❗ Current head 0261f38 differs from pull request most recent head c7d9439. Consider uploading reports for the commit c7d9439 to get more accurate results

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   91.47%   91.03%   -0.44%     
==========================================
  Files          86       91       +5     
  Lines        1701     1841     +140     
  Branches      109      114       +5     
==========================================
+ Hits         1556     1676     +120     
- Misses        119      139      +20     
  Partials       26       26              

Flag	Coverage Δ
e2e	78.70% <69.73%> (-1.02%)	⬇️
unittests	79.42% <88.13%> (+1.00%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/components/cylc/tree/TreeItem.vue	100.00% <ø> (ø)
src/layouts/Default.vue	100.00% <ø> (ø)
src/store/options.js	100.00% <ø> (ø)
src/views/Workflow.vue	92.85% <ø> (ø)
src/components/cylc/table/callbacks.js	80.00% <80.00%> (ø)
src/services/workflow.service.js	91.45% <81.25%> (-1.69%)	⬇️
src/components/cylc/table/deltas.js	83.07% <83.07%> (ø)
src/components/cylc/table/Table.vue	100.00% <100.00%> (ø)
src/graphql/queries.js	100.00% <100.00%> (ø)
src/store/table.module.js	100.00% <100.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0932f42...c7d9439. Read the comment docs.

[kinow]

First quick review 👍

[datamel]

@giulianoserrao, my vue is not really up to scratch enough to review, just just to say looks like a substantial piece of work, congrats!

[giulianoserrao]

@giulianoserrao, my vue is not really up to scratch enough to review, just just to say looks like a substantial piece of work, congrats!

Thanks @datamel - it's been really challenging, yet fun. I must say, without Bruno and Hilary I would NOT have gone this far! :)

[giulianoserrao]

@giulianoserrao can you apply this diff to get the offline mode working, please?

diff --git a/src/services/mock/workflow.service.mock.js b/src/services/mock/workflow.service.mock.js
index de00c2cc..b4d05500 100644
--- a/src/services/mock/workflow.service.mock.js
+++ b/src/services/mock/workflow.service.mock.js
@@ -217,7 +217,8 @@ class MockWorkflowService extends GQuery {
       data: {
         deltas: {
           added: {
-            workflow: checkpoint.workflows[0]
+            workflow: checkpoint.workflows[0],
+            taskProxies: checkpoint.workflows[0].taskProxies
           }
         },
         workflows: checkpoint.workflows

Done

[kinow]

Pushed one commit to fix the Workflow view in the offline mode (mode which e2e tests run in GitHub actions). The e2e tests were failing as the workflow widgets were empty.

[kinow]

Rebased fixing conflicts.

[hjoliver]

Had another good play with this, tests now passing. All good 🎉 Thanks @AaronDCole for finishing the branch off (esp.: views driven by shared datastore only). As discussed at last project meeting, merging this as-is; further changes to the tableview can be done as follow-ups.