Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a single object to receive the deltas of workflow-subscriptions #684

Closed
kinow opened this issue Jun 3, 2021 · 0 comments · Fixed by #543
Closed

Create a single object to receive the deltas of workflow-subscriptions #684

kinow opened this issue Jun 3, 2021 · 0 comments · Fixed by #543
Assignees
Milestone

Comments

@kinow
Copy link
Member

kinow commented Jun 3, 2021

Describe exactly what you would like to see in an upcoming release

At the moment we have the CylcTree object which works well for the Tree View. But we want to have another structure, that is created before the CylcTree.

This structure will be shared by multiple workflow views, like Table view, Tree view, and Graph view.

It will receive any deltas from a workflow-subscription (ideally merged sub of all the views, to be discussed elsewhere). Once a delta is applied to this structure, it must notify any listener/observer via Vue reactivity.

Additional context

The CylcTree uses a flat lookup map (JS Map object). This object could be our flat object, passed around to other views, that can filter it, or derive new structure like CylcTree, or some array for the Table View.

One premise that must be followed, is to avoid duplication. So if a delta arrives for a subscription, we want to get that object from the delta, and store it only once. We can have pointers/references to this object. But we must not duplicate it.

This object should work with the current Tree view, and with the new Table view in #672

Pull requests welcome!

@kinow kinow self-assigned this Jun 3, 2021
@kinow kinow added this to the 0.5.0 milestone Jun 3, 2021
@kinow kinow pinned this issue Jun 3, 2021
@kinow kinow mentioned this issue Jun 23, 2021
9 tasks
@kinow kinow unpinned this issue Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant