Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: add more documentation #5611

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jul 3, 2023

Partially addresses: #5612

There are a few folks poking around with the GraphQL schema which is great, but the documentation is a bit lacking.

Add a quick description to the most commonly used fields.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added the doc Documentation label Jul 3, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.2.0 milestone Jul 3, 2023
@oliver-sanders oliver-sanders self-assigned this Jul 3, 2023
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +913 to +914
configuration as opposed to task "instances" which you will find
in the `TaskProxies` field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

Suggested change
configuration as opposed to task "instances" which you will find
in the `TaskProxies` field.
configuration as opposed to dynamic task "instances" which you
will find in the `TaskProxies` field.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about "dynamic" (note some fields on the Task are dynamic).

@oliver-sanders
Copy link
Member Author

Going to go with single approval for these docs.

@oliver-sanders oliver-sanders merged commit 125c443 into cylc:master Jul 4, 2023
@oliver-sanders oliver-sanders deleted the schema-docs branch July 4, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants