Fix clock-trigger offset computation. #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
reviewed
Nov 15, 2021
hjoliver
force-pushed
the
clock-trigger-fix
branch
5 times, most recently
from
28b1cdb to
d05238c
Compare
hjoliver
force-pushed
the
clock-trigger-fix
branch
from
d05238c to
383ee52
Compare
|
Ready for review @wxtim. See updated description above. |
hjoliver
commented
Dec 21, 2021
|
|
||
| [scheduler] | ||
| cycle point time zone = '+0530' | ||
| # Default to time zone Z |
There was a problem hiding this comment.
(This test also fails on master, if system time is local in my timezone).
There was a problem hiding this comment.
I'm working my a home pc, so I can jimmy the system clock to test this.
wxtim
approved these changes
Dec 21, 2021
| @@ -297,6 +301,26 @@ def get_point_as_seconds(self): | |||
| self.point_as_seconds += utc_offset_in_seconds | |||
| return self.point_as_seconds | |||
|
|
|||
| def get_clock_trigger_time(self, offset_str): | |||
There was a problem hiding this comment.
This feels like it might be nice to unit test it: It would make fixing any future issues with this easier.
MetRonnie
requested changes
Jan 4, 2022
Co-authored-by: Ronnie Dutta <[email protected]>
|
Unit test added. |
MetRonnie
reviewed
Jan 6, 2022
MetRonnie
approved these changes
Jan 6, 2022
Co-authored-by: Ronnie Dutta <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #4510
Fixes clock-trigger time computation for clock xtriggers and old-style (task property) clock triggers. Also restore main-loop call to check old-style clock-triggers (must have lost that somewhere during Cylc 8 development).
The new way is very efficient, even for inexact offsets (months, years): the computation is done once at first call (add offset to cycle point, then convert to absolute trigger time in seconds since unix epoch which is used for all subsequent checks.
TODO:is there a less convoluted way to do the offset computation?this is probably quite inefficient compared to the old broken way? (complex ISO datetime computation in every clock check, instead of a simple float subtraction). Can this be mitigated?Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.pyandconda-environment.yml.