-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate implicit task names #4399
Validate implicit task names #4399
Conversation
77395c1
to
cc74aad
Compare
cc74aad
to
51d7641
Compare
51d7641
to
1428676
Compare
@oliver-sanders - note I pushed a trivial test fix to your branch, to see if all tests will pass here now. |
... they do 🎉 ... any reason this is still a Draft? Change log entry? |
Waiting for me to get around to rebasing, branch got in a mess. |
8bb1269
to
0a78b40
Compare
0a78b40
to
fc31081
Compare
Should this:
validate? I don't think it should, but it does for me. |
fc31081
to
9787622
Compare
Good catch, it turns out that the graph parser was expanding Fixed and extended the test to cover this. |
9787622
to
ce60824
Compare
Built on #4343Fixes small bug spotted whilst reviewing #4343 where it is possible to define
root
as an implicit task.Also reserves
_cylc.*
in xtriggers and task names (used by internal xtriggers).Testing checklist:
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.py
andconda-environment.yml
.