host -> platform #4164
Merged
host -> platform #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
oliver-sanders
commented
Apr 8, 2021
cylc/flow/network/schema.py
Outdated
Comment on lines
772
to
774
| host = String( | ||
| deprecation_reason='Use the platform field' | ||
| ) |
There was a problem hiding this comment.
Turns out we can deprecate GraphQL fields, I think I'll just remove this one (since it will always return None and we are the only users ATM), however, worth knowing.
The field gets highlighted in GraphiQL along with the deprecation reason.
There was a problem hiding this comment.
Removed (not needed).
oliver-sanders
force-pushed
the
host-platform
branch
2 times, most recently
from
1476d9d to
a533018
Compare
oliver-sanders
force-pushed
the
host-platform
branch
from
a533018 to
bc41d91
Compare
|
(incase this gets tangled up with DNS issues I ran all tests locally) |
kinow
approved these changes
Apr 13, 2021
hjoliver
approved these changes
Apr 14, 2021
|
(Tests fails look like the DNS issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Protobuf and GraphQL APIs both provide
hostand not platform for jobs.Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.