Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove dud test #4054

Merged
merged 1 commit into from
Jan 31, 2021
Merged

tests: remove dud test #4054

merged 1 commit into from
Jan 31, 2021

Conversation

oliver-sanders
Copy link
Member

closes #4052

Remove test that is broken and that I think is no longer applicable, see #4052 (comment)

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.
  • No dependency changes.

@oliver-sanders oliver-sanders added this to the cylc-8.0a3 milestone Jan 29, 2021
@oliver-sanders oliver-sanders self-assigned this Jan 29, 2021
hjoliver
hjoliver approved these changes Jan 31, 2021
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@hjoliver hjoliver merged commit 387bdb2 into cylc:master Jan 31, 2021
@oliver-sanders oliver-sanders deleted the dud-test branch February 1, 2021 09:40
@hjoliver hjoliver modified the milestones: cylc-8.0a3, cylc-8.0b0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
cylc-8.0b0
Development

Successfully merging this pull request may close these issues.

tests/k/hold-release/13-ready-restart.t not working
2 participants
@oliver-sanders @hjoliver