Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading of global.rc #2601

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Conversation

matthewrmshin
Copy link
Contributor

Load the relatively costly module and global configuration files only on demand.

This change should also allow reload of global configuration in the future. (This will be useful for solving suite host auto re-selection functionality described in #988 and #1885.)

@matthewrmshin matthewrmshin added this to the soon milestone Mar 19, 2018
@matthewrmshin matthewrmshin self-assigned this Mar 19, 2018
Load expensive module only if required.
Allow reload.
@matthewrmshin matthewrmshin modified the milestones: soon, next release Mar 19, 2018
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@oliver-sanders oliver-sanders merged commit 9a7fbf3 into cylc:master Mar 20, 2018
@matthewrmshin matthewrmshin deleted the lazy-glbl-cfg branch March 21, 2018 12:29
@oliver-sanders oliver-sanders mentioned this pull request Nov 16, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants